perf: add ability to ignore inconsistent solutions#2396
Open
Christopher-Chianelli wants to merge 1 commit into
Open
perf: add ability to ignore inconsistent solutions#2396Christopher-Chianelli wants to merge 1 commit into
Christopher-Chianelli wants to merge 1 commit into
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a new preview feature
IGNORE_INCONSISTENT_SOLUTIONS.When enabled, when a move causes the solution to be in an inconsistent state, that move is effectively ignored;
calculateScorewill return a score with the minimum init value possible (i.e. a score that is less than all other scores) and no shadow variables will be updated.Technically, this potentially introduces a score trap: all inconsistent solutions get the same -infinity score. However, this doesn't seem to be a problem in the benchmarks I performed.
TopologicalGraph#commitChangessignature has changed to return a boolean which is true iff the graph has loops (and thus the solution inconsistent.Benchmarks show significant improvements for Machine Job Scheduling on Enterprise.